Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typings onFile #223

Merged
merged 1 commit into from
Apr 21, 2021
Merged

fix: typings onFile #223

merged 1 commit into from
Apr 21, 2021

Conversation

climba03003
Copy link
Member

@climba03003 climba03003 commented Apr 20, 2021 •
edited
Loading

Resolve: #201

As changing the function itself will break most of ppl using this plugin. I am +1 on changing the type definition to resolve the issue mention above.

Checklist

@climba03003 climba03003 requested a review from a team April 20, 2021 03:44
L2jLiga
L2jLiga approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@L2jLiga L2jLiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

mcollina
mcollina approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fox1t
fox1t approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@climba03003 climba03003 merged commit 8112421 into fastify:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@fox1t fox1t fox1t approved these changes

@L2jLiga L2jLiga L2jLiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript definition for onFile is incorrect when attachFieldsToBody is true
4 participants
@climba03003 @mcollina @fox1t @L2jLiga