Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs #1276

Closed
wants to merge 1 commit into from

Conversation

ryangalamb
Copy link

More info in this thread: actions/setup-python#962

Announcement for moving ubuntu-latest to 24.04: actions/runner-images#10636
It says that the setup-python action should be able to install 3.7, but the discussion in actions/setup-python#962 (and the failing pipelines in this repo) say otherwise.

@ryangalamb ryangalamb changed the title ci: use ubuntu-22.04 for jobs that need py 3.7 👷 Fix py3.7 tests, use ubuntu-22.04 for test jobs Jan 28, 2025
@AlanBogarin
Copy link
Contributor

AlanBogarin commented Feb 3, 2025

Currently most pulls fail tests due to this issue with 3.7

@dolfandringa
Copy link

dolfandringa commented Feb 19, 2025

@ryangalamb Would it be possible to merge this, so #1226 can be unblocked?

@ryangalamb
Copy link
Author

I don't have the ability to merge.

@tiangolo when you get a chance, could you please take a look at this? All CI pipelines are failing without this fix 🙏

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ryangalamb,

I totally missed this PR, sorry!

I've actually been wanting to upgrade the test suite further to also test on different OS's, see #1290. Only I've been running into time-out issues with smokeshow 😭
But I'm looking into this and will sort things out. In the meantime, testing on Python 3.7 has been temporarily disabled.

This PR would have definitely been a good quick fix though, I'm sorry I didn't see it sooner. Thanks for contributing! Really appreciate it. I'll go ahead and close this now, but I'll continue working on getting the CI in a proper state again.

In the meantime, at least other PRs should go greeen again with 3.7 temporarily disabled (though admittedly not ideal).

@svlandeg svlandeg closed this Feb 20, 2025
@svlandeg
Copy link
Member

Now fixed with #1309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants