Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAI-3432 - Support application tags & paths #93

Merged
merged 6 commits into from
Oct 19, 2022
Merged

FAI-3432 - Support application tags & paths #93

merged 6 commits into from
Oct 19, 2022

Conversation

willmarks
Copy link
Collaborator

Allows passing multiple tags and paths on a CD event that will be associated with the application being deployed.

@willmarks willmarks requested a review from tovbinm October 14, 2022 17:03
README.md Outdated
@@ -273,6 +273,8 @@ There are two ways that arguments can be passed into the script. The first, is v
| ‑‑deploy_status_details | Any extra details about the status of the deployment. | --deploy |
| ‑‑deploy_url | The url of the deployment. | --deploy |
| ‑‑deploy_app_platform | The compute platform that runs the application. | --deploy |
| ‑‑deploy_app_tags | A comma separated array of `key:value` application tags. (e.g. `key1:value1,key2:value2`) | --deploy |
| ‑‑deploy_app_paths | A comma separated array of application paths. (e.g. `a/b/c,d/e/f`) | --deploy |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comma separated array of application slash separated paths. (e.g. `aws/us-east-1/eks-001,aws/us-west-2/eks-002`)

faros_event.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@tovbinm tovbinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@willmarks willmarks merged commit f6f4047 into main Oct 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants