Passthrough start time & end time #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanna add a note about it in the README? + bump version |
tovbinm
approved these changes
Apr 8, 2022
tovbinm
approved these changes
Apr 9, 2022
|
Hmm. I realized that my Readme changes apply to both community edition and enterprise. @ypc-faros is it possible for community edition to also support all of these various forms of timestamps? |
|
@willmarks let's merge. And let's create an issue here to follow up on this - https://github.com/faros-ai/faros-community-edition/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
With this Event API change we can now pass through the string that is provided for timestamps to the Event CLI. This now allows us to support ISO timestamps and 'Now'.