Added ShellCheck check #55
Conversation
|
It really doesn't like the way we use colors with printf |
| }' <<< "$request_body" | ||
| ) | ||
| fi | ||
| if ! [ -z "$run_name" ]; then |
There was a problem hiding this comment.
I think passing run_name was missing - so I added it.
There was a problem hiding this comment.
how do I test for it?
There was a problem hiding this comment.
We need to find all the mutations where this needs to be added as a parameter and add it to their request body. Also, unfortunately the rest endpoint mutations need to be changed first, otherwise they'll fail on unexpected param (see https://github.com/hasura/graphql-engine/blob/master/rfcs/rest-endpoints.md#response-codes)
Maybe we can make these changes in a separate PR(s).
There was a problem hiding this comment.
how do I test for it?
The tests just compare the expected and actual payload to hasura rest endpoints.
| ) | ||
| fi | ||
| } | ||
|
|
||
| function sendEventToFaros() { | ||
| log "Sending event to Faros..." | ||
|
|
||
| http_response=$(curl --retry 5 --retry-delay 5 \ | ||
| --silent --write-out "HTTPSTATUS:%{http_code}" -X POST \ | ||
| http_response=$(curl -s -S --retry 5 --retry-delay 5 \ |
There was a problem hiding this comment.
-S was added to print connection errors out as well
…i into tovbinm-patch-2
About
Added ShellCheck check eliminate bugs in the shell script
Screenshots
Extras