Add --no-artifact param and simplify readme #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmarks
approved these changes
Nov 15, 2023
README.md
Outdated
|
|
||
| ```sh | ||
| ./faros_event.sh CI -k "<faros_api_key>" \ | ||
| --run "<run_source>://<run_organization>/<run_pipeline>/<run_id>" \ | ||
| --run_status "Success" \ | ||
| --run_end_time "Now" | ||
| --artifact "<artifact_source>://<artifact_organization>/<artifact_repository>/<artifact_id>" |
There was a problem hiding this comment.
--artifact is dependent on --commit being provided in a partial CI event. It can't be split across partial events unfortunately.
|
When can we merge this @willmarks ? Should I remove the --ci-only option so we can merge? |
|
Yeah we can remove the --ci-only option and merge |
willmarks
approved these changes
Nov 27, 2023
willmarks
reviewed
Nov 27, 2023
faros_event.sh
Outdated
| @@ -114,6 +114,7 @@ function help() { | |||
| echo "--run_name | |" | |||
| echo "--run_start_time | | e.g. 1626804346019 (milliseconds since epoch)" | |||
| echo "--run_end_time | | e.g. 1626804346019 (milliseconds since epoch)" | |||
| echo "--ci_only Use if CI event does not generate artifact. No --artifact param supplied." | |||
There was a problem hiding this comment.
nit: we have been constructing a table of sorts with |s
|
Kudos, SonarCloud Quality Gate passed!
|
snabar
changed the title
snabar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.