[FAI-15030] Release airbyte cli binaries in the github release #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeniii
changed the title
jeniii
commented
Feb 14, 2025
.github/workflows/ci.yaml
Outdated
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: release_${{ env.TARGET }} | ||
| path: airbyte-local-cli-nodejs/out/pkg/airbyte-local-${{ env.TARGET }}.zip |
There was a problem hiding this comment.
don't have a specific reason to use zip other than it seems like windows use zip and doesn't natively do tar
|
cjwooo
approved these changes
Feb 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested on the branch https://github.com/faros-ai/airbyte-local-cli/actions/runs/13319320969
I tried download and ran macos arm64 one and it worked. haven't tried other ones. I'm so confident the windows one work as expect but i will figure it out when i do testing on windows later
Type of change