Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAI-14708 Fix initialization bug #1914

Merged
merged 1 commit into from
Feb 13, 2025
Merged

FAI-14708 Fix initialization bug #1914

merged 1 commit into from
Feb 13, 2025

Conversation

ypc-faros
Copy link
Contributor

@ypc-faros ypc-faros commented Feb 13, 2025

Description

Fixes Cannot access 'isResetSync' before initialization

It's safe to assume isResetSync => false since the definition has !sourceConfigReceived as one of its conditions. And sourceConfigReceived is set to true in the same code path.

Type of change

  • Bug fix
  • New feature
  • Breaking change

Related issues

Fix #1

Migration notes

Describe migration notes if any

Extra info

Add any additional information

@ypc-faros ypc-faros marked this pull request as ready for review February 13, 2025 16:03
@ypc-faros ypc-faros merged commit 514d989 into main Feb 13, 2025
8 checks passed
@ypc-faros ypc-faros deleted the ypc/m2 branch February 13, 2025 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants