remove loop in savemphtxt #50
Conversation
|
thanks for the patch - unfortunately I can't accept this one. the changes must be local and minimal, you should also not to remove the help info and the original author info. if you are interested in revising this patch, please restore most of the changes (including white spaces), and keep the modifications to the least number of lines, and ensure no change to the functionality. |
|
I had added the author info back and committed again. |
savemphtxt.m
Outdated
| @@ -1,5 +1,4 @@ | |||
| function savemphtxt(node, face, elem, filename) | |||
| % | |||
There was a problem hiding this comment.
can you restore this empty line? without it, matlab has different behaviors
savemphtxt.m
Outdated
| for i = 1:n_face | ||
| fprintf(fp,'%d %d %d\n',face(i,1),face(i,2),face(i,3)); | ||
| end | ||
| % for i = 1:n_face |
There was a problem hiding this comment.
please remove these commented lines if they are no longer needed. git keeps track of all edit history, so no need to keep those in the code.
|
I missed the meshreorient line because my iso2mesh version is rather old. And I had rearranged my file. How about the third committed file? |
as title discription. The fprintf function in for large loop takes too long time.