Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown chain logo #29

Merged
merged 3 commits into from
Oct 24, 2022
Merged

Fix unknown chain logo #29

merged 3 commits into from
Oct 24, 2022

Conversation

Bridgerz
Copy link
Contributor

I noticed if the Wagmi configuration has chains not included in the default supported chains list, the "Unknown Chain" logo only appears in the chain select dropdown and not in the ConnectKitModal or ConnectKitButton components. Very easy fix. Thanks for creating such a beautiful project!

@vercel
Copy link

vercel bot commented Oct 18, 2022

@Bridgerz is attempting to deploy a commit to the LFE Team on Vercel.

A member of the Team first needs to authorize it.

@Bridgerz
Copy link
Contributor Author

@lochie Could we merge this in? its super minimal :)

@vercel
Copy link

vercel bot commented Oct 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
connectkit-cra ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 0:20AM (UTC)
connectkit-testbench ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 0:20AM (UTC)

Copy link
Member

@lochie lochie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice solution, thanks for the contribution @Bridgerz!

@lochie lochie merged commit bb746f3 into family:main Oct 24, 2022
@Bridgerz
Copy link
Contributor Author

@lochie When can we expect these changes to reflect in the node package?

@lochie
Copy link
Member

lochie commented Oct 25, 2022

@Bridgerz we're looking towards some time later this week to push up a patch with these recent changes.
We'll announce it on Twitter.

lochie added a commit that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants