-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(driver/bpf): fix sys_poll_x verifier bug on fedora 40 #2095
Conversation
Signed-off-by: albe19029 <[email protected]>
Welcome @albe19029! It looks like this is your first PR to falcosecurity/libs 🎉 |
Please double check driver/SCHEMA_VERSION file. See versioning. /hold |
Reworked PR body to meet our contributions standards :) |
Running kernel-tests against this PR https://github.com/falcosecurity/libs/actions/runs/11232975504 |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2095 +/- ##
=======================================
Coverage 73.69% 73.69%
=======================================
Files 253 253
Lines 31914 31914
Branches 5642 5635 -7
=======================================
+ Hits 23519 23520 +1
+ Misses 8395 8394 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
X64 matrix:
Arm64 matrix:
All green! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: d10b2c2a761f578f2a9c915d670e10c94157525b
|
/milestone next-driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: albe19029, Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-bpf
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2094
Special notes for your reviewer:
Does this PR introduce a user-facing change?: