-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: remove some commits from the blame #2093
Conversation
Signed-off-by: Andrea Terzolo <[email protected]>
8b449c0
to
7a0ae77
Compare
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2093 +/- ##
=======================================
Coverage 73.57% 73.57%
=======================================
Files 253 253
Lines 31875 31875
Branches 5629 5637 +8
=======================================
Hits 23452 23452
- Misses 8393 8400 +7
+ Partials 30 23 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 9e903b54b2f38f4086861464e3e65d5a266462e1
|
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR removes some commits from the blame since they just convert types from u32 to uint32_t and similar. When looking for information like when a field was added to a struct it would be better to ignore these commits
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: