Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove some commits from the blame #2093

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

This PR removes some commits from the blame since they just convert types from u32 to uint32_t and similar. When looking for information like when a field was added to a struct it would be better to ignore these commits

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

github-actions bot commented Oct 2, 2024

Perf diff from master - unit tests

     1.86%     +0.88%  [.] sinsp::fetch_next_event
     1.92%     -0.81%  [.] sinsp_parser::event_cleanup
     0.92%     +0.61%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     4.10%     +0.59%  [.] sinsp_parser::process_event
     2.12%     -0.59%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     0.84%     +0.56%  [.] sinsp_filter_check::parse_field_name
     3.56%     -0.49%  [.] sinsp_thread_manager::get_thread_ref
     5.36%     -0.43%  [.] next
     0.99%     -0.41%  [.] sinsp_evt::get_direction
     0.49%     +0.41%  [.] scap_event_has_large_payload

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0018         -0.0018           153           153           153           153
BM_sinsp_split_median                                          +0.0026         +0.0026           153           154           153           154
BM_sinsp_split_stddev                                          -0.1924         -0.1936             2             1             2             1
BM_sinsp_split_cv                                              -0.1910         -0.1922             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0832         +0.0832            59            63            59            63
BM_sinsp_concatenate_paths_relative_path_median                +0.0793         +0.0793            59            63            59            63
BM_sinsp_concatenate_paths_relative_path_stddev                -0.2266         -0.2274             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.2860         -0.2867             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0068         +0.0068            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   +0.0018         +0.0018            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   +4.1621         +4.1702             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +4.1273         +4.1354             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0741         +0.0741            57            61            57            61
BM_sinsp_concatenate_paths_absolute_path_median                +0.0642         +0.0642            57            61            57            61
BM_sinsp_concatenate_paths_absolute_path_stddev                +1.9255         +1.9239             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.7237         +1.7222             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0096         +0.0095           394           397           394           397
BM_sinsp_split_container_image_median                          +0.0098         +0.0098           393           397           393           397
BM_sinsp_split_container_image_stddev                          +0.0249         +0.0237             2             2             2             2
BM_sinsp_split_container_image_cv                              +0.0152         +0.0141             0             0             0             0

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (85713d3) to head (7a0ae77).
Report is 40 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2093   +/-   ##
=======================================
  Coverage   73.57%   73.57%           
=======================================
  Files         253      253           
  Lines       31875    31875           
  Branches     5629     5637    +8     
=======================================
  Hits        23452    23452           
- Misses       8393     8400    +7     
+ Partials       30       23    -7     
Flag Coverage Δ
libsinsp 73.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Oct 7, 2024

LGTM label has been added.

Git tree hash: 9e903b54b2f38f4086861464e3e65d5a266462e1

@poiana poiana merged commit cfd262e into falcosecurity:master Oct 9, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants