-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cmake): honor CMAKE_BUILD_TYPE while building bundled grpc and protobuf #2043
Conversation
…protobuf. Signed-off-by: Federico Di Pierro <[email protected]>
/milestone 0.19.0 |
My upstream test branch |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2043 +/- ##
=======================================
Coverage 74.31% 74.31%
=======================================
Files 253 253
Lines 30966 30966
Branches 5418 5413 -5
=======================================
Hits 23011 23011
+ Misses 7949 7941 -8
- Partials 6 14 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Another fix needed for
zig
(or well, this makes sense in a broader way, but iszig
that highlighted the issue).Otherwise Falco build would fail at link time because:
Caused by the fact that we built protobuf with
-DNDEBUG
(the default value, ie: release mode) but then we built Falco in Debug mode in PR's CI; then, when linking, we were hit by: protocolbuffers/protobuf#9947Another solution would've been to bump protobuf, but of course it requires to bump grpc and that's a circle of hell.
Don't really know why
g++
nor x86_64 zig were not hit by the issue at all, but zig arm64 was.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: