-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): introduce the first google benchmark #2021
new(tests): introduce the first google benchmark #2021
Conversation
Love this, thank you! |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2021 +/- ##
=======================================
Coverage 74.21% 74.21%
=======================================
Files 253 253
Lines 30845 30845
Branches 5400 5420 +20
=======================================
Hits 22893 22893
- Misses 7925 7952 +27
+ Partials 27 0 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andrea Terzolo <[email protected]>
9623f5c
to
8ca26a1
Compare
|
||
- name: Install a recent version of cmake ⛓️ | ||
run: | | ||
curl -L -o /tmp/cmake.tar.gz https://github.com/Kitware/CMake/releases/download/v3.22.5/cmake-3.22.5-linux-$(uname -m).tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need at least version 3.11
for FetchContent
8ca26a1
to
9fc3014
Compare
33d1c52
to
113083c
Compare
Signed-off-by: Andrea Terzolo <[email protected]>
113083c
to
a05ffdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: 79dc8071fdc435e35fc47bd1f0d30ccd59aa41c8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR introduces the first Google benchmark. This is just the scaffolding we should add more tests to it. For example, a good candidate could be the scap-file benchmark that we are running today in our perf CI @FedeDP
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: