refactor(libsinsp): better clarify filtercheck subclass extracting only one value #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.17.0 |
…ly one value Having `extract` methods all with the same name bacame confusing both to develop on and to review. Co-authored-by: Andrea Terzolo <[email protected]> Signed-off-by: Jason Dellaluce <[email protected]>
jasondellaluce
force-pushed
the
refactor/filtercheck-extract-single
branch
from
fc15171 to
6af13c0
Compare
6 tasks
|
LGTM label has been added. Git tree hash: 645d0e451204d6025ab2776f28ba2c88a45cc4dd
|
leogr
approved these changes
Apr 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind design
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Revieweing and operating with the code area related to filterchecks is becoming more and more confusing due to different methods overridden and having the same name. This PR disambiguates the
extractprotected method responsible of extracting only one value, from the broaderextractthat is part fo the actual public interface.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: