Revert "update(sinsp): implement suppressed tid cache in sinsp_suppress" #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnosek
force-pushed
the
sinsp_revert_cache
branch
from
7f77ac3 to
ab373da
Compare
The cache implementation was broken (a no-op, effectively) but even after fixing it doesn't provide noticeable performance wins. Revert it and save a bit of complexity. This reverts commit 6a9a0ec. Fixes: falcosecurity#1724 Signed-off-by: Grzegorz Nosek <[email protected]>
gnosek
force-pushed
the
sinsp_revert_cache
branch
from
ab373da to
a132f85
Compare
|
LGTM label has been added. Git tree hash: 8565c39ac2b3ec97e03745e9c9931e68b328f9cb
|
LucaGuerra
approved these changes
Mar 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, gnosek, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache implementation was broken (a no-op, effectively) but even after fixing it doesn't provide noticeable performance wins.
Revert it and save a bit of complexity.
This reverts commit 6a9a0ec.
Fixes: #1724
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: