Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(libsinsp): add logging capability to the plugin API #1640

Merged
merged 10 commits into from
Jan 26, 2024
Merged

feat(libsinsp): add logging capability to the plugin API #1640

merged 10 commits into from
Jan 26, 2024

Conversation

mrgian
Copy link
Contributor

@mrgian mrgian commented Jan 23, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #989

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(libsinsp): add logging capability to the plugin API

@poiana poiana requested review from hbrueckner and leogr January 23, 2024 16:22
jasondellaluce
jasondellaluce reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks! This is lovely! I left few minor doc suggestions.

userspace/plugin/plugin_types.h Outdated Show resolved Hide resolved
userspace/plugin/plugin_api.h Outdated Show resolved Hide resolved
@Andreagit97 Andreagit97 added this to the 0.15.0 milestone Jan 24, 2024
mrgian and others added 10 commits January 25, 2024 10:42
@mrgian
feat(libsinsp): add logging capabilities to plugin api
789874a 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian
fix(libsinsp): use const char pointers in plugin_api
d4c5444 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian
new(libsinsp): add logging to plugin examples
089d50f 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian
new(libsinsp): add component string to plugin log function
841580e 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian
chore(libsinsp): add more detailed docs to plugin_api
25c2ef3 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian
refactor(libsinsp): better plugin logging function naming
51049e7 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian
new(libsinsp): add unit test for plugin logging
ff9e752 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian
update(userspace/plugin): bump plugin API version
7b58edf 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
@mrgian @jasondellaluce
chore(userspace/plugin): improved docs in plugin api
08794fd 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
Co-authored-by: Jason Dellaluce <[email protected]>
@mrgian
new(libsinsp): fallback to plugin name when logging component is null
6c0db3a 
Signed-off-by: Gianmatteo Palmieri <[email protected]>
FedeDP
FedeDP approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Great work @mrgian!!

@poiana poiana added the lgtm label Jan 26, 2024
@poiana
Copy link
Contributor

poiana commented Jan 26, 2024

LGTM label has been added.

Git tree hash: d5aa4663e886493050dd88ca0f45ad7b22141845

jasondellaluce
jasondellaluce approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

/approve

@poiana
Copy link
Contributor

poiana commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fd72377 into falcosecurity:master Jan 26, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@FedeDP FedeDP FedeDP approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@leogr leogr Awaiting requested review from leogr

Assignees

@FedeDP FedeDP

@jasondellaluce jasondellaluce

Labels
approved area/libsinsp dco-signoff: yes kind/feature New feature or request lgtm release-note size/L
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

[New Feature] Standard logging in Plugin API
5 participants
@mrgian @poiana @FedeDP @jasondellaluce @Andreagit97