improve the name of the prometheus metrics #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issif
force-pushed
the
fix/prometheus-naming-convention
branch
from
dcaa362 to
343cd04
Compare
Issif
changed the title
…e and the naming convention chosen by Falco Signed-off-by: Thomas Labarussias <[email protected]>
Issif
force-pushed
the
fix/prometheus-naming-convention
branch
from
343cd04 to
f2da4e3
Compare
Issif
changed the title
|
Looks good to me! |
leogr
approved these changes
Oct 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: e9af7cb95e57bd13e59764209e646b2a410c3e39
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
What this PR does / why we need it:
With its recent releases, Falco comes now out of the box with prometheus metrics, all the metrics follow the convention
falcosecurity_<project>_<metric>_<type>.projectrepresents the project, it can befalco,falcosidekick(goal of this PR),talon, ...This PR introduces the prefix
falcosecurity, addfalcosidekickas project, and thetypeastotal(all metrics are counters for now)To be compliant with the labels used by
falcoand be compliant with the already existing rules from the falco-exporter, the labelpriorityhas been changed topriority_rawandprioritynow contains an int.Warning
By changing the names, this PR introduces a breaking change. All dashboards or configured alerts will have to be updated, the Changelog and the blog post following the next release will explain that for the end users.
Which issue(s) this PR fixes:
#940
Fixes #
Special notes for your reviewer: