Reuse http client #962
Merged
Reuse http client #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @aleksmaus! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
Signed-off-by: Aleksandr Maus <[email protected]>
aleksmaus
force-pushed
the
feature/reuse_http_client
branch
from
7cbd6f6 to
c5c5208
Compare
Signed-off-by: Aleksandr Maus <[email protected]>
aleksmaus
force-pushed
the
feature/reuse_http_client
branch
from
9a7a03f to
3a7bd98
Compare
|
Hi, This is an interesting PR, thanks. I can't review for now, I'm on a family road trip for 2 weeks. Will review when I'm back |
Thank you! Have a great trip! |
…s nil, err Signed-off-by: Aleksandr Maus <[email protected]>
aleksmaus
force-pushed
the
feature/reuse_http_client
branch
from
b1670e6 to
856400f
Compare
This was referenced Aug 12, 2024
|
LGTM label has been added. Git tree hash: de419f827e62e07c36d901ac91486cb2cba4e26f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleksmaus, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR reuses http.Client instance for the outputs, were it was previously created per each request.
The http.Client reuse is recommended:
https://cs.opensource.google/go/go/+/refs/tags/go1.22.6:src/net/http/client.go;l=34
We are seeing 3-4x increase of throughput for Elasticsearch output in out tests.
I tried to keep the approach to the http client and the transport creation the same as before, namely logging and continuing on error, extracted some code into the function.