cardinality matters, n_events labels on alertmanager #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epcim: There is not a label identifying the kind of this PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @leodido |
|
/king bug |
Issif
requested changes
Sep 4, 2020
epcim
force-pushed
the
fix_cardinality_n_events
branch
from
7bd3043 to
a40d439
Compare
poiana
added
dco-signoff: yes
dco-signoff: no
and removed
dco-signoff: no
dco-signoff: yes
labels
Signed-off-by: Petr Michalec <[email protected]>
epcim
force-pushed
the
fix_cardinality_n_events
branch
from
6a0d325 to
b64b61f
Compare
|
/approve |
Issif
approved these changes
Sep 4, 2020
|
LGTM label has been added. Git tree hash: 3c6320b49f2bff262e36e6fc85807ec60c063a4d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
with n_events* metrics, we send actual values as labels to alertmanager -> which increases cardinality and makes impossible to aggregate alerts later.