Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticsearch-doc): remove mattermost configuration coming from a cc/cl mistake #740

Merged

Conversation

idrissneumann
Copy link
Contributor

What type of PR is this?

/kind documentation

Any specific area of the project related to this PR?

/area config

What this PR does / why we need it:

Remove mattermost config variable which were probably cc/cl by mistake

@poiana poiana requested review from Issif and leogr January 2, 2024 14:53
@idrissneumann idrissneumann changed the title feat(elasticsearch-doc): remove mattermost configuration coming from a cc/cl error feat(elasticsearch-doc): remove mattermost configuration coming from a cc/cl mistake Jan 2, 2024
@idrissneumann idrissneumann force-pushed the fix_elastic_documentation branch from f5e2cdf to 13b5437 Compare January 2, 2024 14:55
@idrissneumann idrissneumann changed the title feat(elasticsearch-doc): remove mattermost configuration coming from a cc/cl mistake fix(elasticsearch-doc): remove mattermost configuration coming from a cc/cl mistake Jan 2, 2024
@idrissneumann idrissneumann force-pushed the fix_elastic_documentation branch from 13b5437 to aa97b78 Compare January 2, 2024 15:26
@idrissneumann idrissneumann force-pushed the fix_elastic_documentation branch from aa97b78 to 4471113 Compare January 2, 2024 15:26
@poiana poiana added the lgtm label Jan 2, 2024
@poiana
Copy link

poiana commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idrissneumann, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 2, 2024

LGTM label has been added.

Git tree hash: 5f79d6a1c35a5da49e768e056531bd1d69c52c7c

@poiana poiana added the approved label Jan 2, 2024
@Issif Issif added this to the 2.29.0 milestone Jan 2, 2024
@poiana poiana merged commit 4bd17ae into falcosecurity:master Jan 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants