🔧 Add NS and pod by default in loki output #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: afreyermuth98 <[email protected]>
|
If this PR is approved, I would add the modification of the grafana dashboard so it fits with |
Signed-off-by: afreyermuth98 <[email protected]>
Signed-off-by: afreyermuth98 <[email protected]>
Issif
approved these changes
Jan 17, 2025
|
LGTM label has been added. Git tree hash: 340d8f88349589e585eb427421b4f6d8bdb78d8d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreyermuth98, Issif The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind design
Any specific area of the project related to this PR?
/area outputs
What this PR does / why we need it:
This PR puts the namespace and pod name as default fields in the loki output if they exist.
This is really useful to have a good setup at start and do not go into the
extraLabelsconfig as they are important keys to get.Moreover, some of these labels are used by default by the dashboard, so it would be perfect if all the deployment (loki + dashboard) is working without extra configuration needed