Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add message thread id in telegramPayload #1008

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

vashian
Copy link
Contributor

@vashian vashian commented Sep 24, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

This enhancement allows for better control over message threading in Telegram.

@poiana
Copy link

poiana commented Sep 24, 2024

Welcome @vashian! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

@poiana poiana added the size/XS label Sep 24, 2024
@Issif Issif added this to the 2.30 milestone Sep 24, 2024
Issif
Issif previously approved these changes Sep 24, 2024
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all good to me, well done

@poiana
Copy link

poiana commented Sep 24, 2024

LGTM label has been added.

Git tree hash: 23b891346ed2f1c751f78ca256fcbf677b8501dc

@Issif
Copy link
Member

Issif commented Sep 24, 2024

Can you sign off your commits please, the CI will decline the merge without.

@vashian
Copy link
Contributor Author

vashian commented Sep 25, 2024

Can you sign off your commits please, the CI will decline the merge without.

I’ve signed off all my commits as requested.

@Issif
Copy link
Member

Issif commented Sep 25, 2024

There's still a linting issue:

image

Signed-off-by: Mohammadreza <[email protected]>
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, it will be released with the v2.30.0, I don't have any ETA for now

@poiana poiana added the lgtm label Sep 25, 2024
@poiana
Copy link

poiana commented Sep 25, 2024

LGTM label has been added.

Git tree hash: cc331ab4f952bf5446a5d01fe5a8c774877d7fd6

@poiana
Copy link

poiana commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, vashian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b3cc550 into falcosecurity:master Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants