Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes to "no"-key #2592

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Add quotes to "no"-key #2592

merged 4 commits into from
Oct 18, 2022

Conversation

Frubrecht
Copy link
Contributor

Summary

Adding quotes to "no"-key in es-AR.yml and hy.yml, so they don't get interpreted as booleans

@professorjrod
Copy link
Contributor

professorjrod commented Oct 18, 2022

Interesting. Apparently there are quite a few of these keywords:
https://yaml.org/type/bool.html
y|Y|yes|Yes|YES|n|N|no|No|NO
|true|True|TRUE|false|False|FALSE
|on|On|ON|off|Off|OFF

@psibi psibi merged commit 1723157 into faker-ruby:main Oct 18, 2022
@psibi
Copy link
Member

psibi commented Oct 18, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants