Automate workflow to publish to RubyGems. #2584
Conversation
Signed-off-by: sudeeptarlekar <[email protected]>
bijoysijo
changed the title
.github/workflows/publish.yml
Outdated
| push: | ||
| tags: | ||
| - "v*" | ||
| pull_request: |
There was a problem hiding this comment.
I don't think we need to push gem to rubygems.org when we merge any PR to main branch, I added this for my testing purpose. Make sure we need this before merging.
Other things I think are quite self explanatory, the only part I was stuck/unsure of how are we going to handle secrete tokens?
There was a problem hiding this comment.
Makes sense. I'll remove the pull_request part.
There was a problem hiding this comment.
@vbrazo do we have the Ruby gem host key in the Settings? If not, we might need to add it for this to work.
There was a problem hiding this comment.
hi @bijoysijo thank you for your contribution to Faker! I left a comment, let me know what you think.
I am a bit confused by the description of this PR. The branch was renamed to main a couple of days ago. Could you please update the description with the reason why behind the changes? Thanks!
.github/workflows/publish.yml
Outdated
| - uses: chrnorm/deployment-action@releases/v1 | ||
| name: Create GitHub deployment | ||
| id: deployment | ||
| with: | ||
| token: "${{ github.token }}" | ||
| target_url: ${{ env.TARGET_URL }} | ||
| environment: production |
There was a problem hiding this comment.
we don't have deployments or environments, so I don't think we need this step.
.github/workflows/publish.yml
Outdated
| - name: Update deployment status (success) | ||
| if: success() | ||
| uses: chrnorm/deployment-status@releases/v1 | ||
| with: | ||
| token: "${{ github.token }}" | ||
| target_url: ${{ env.TARGET_URL }} | ||
| state: "success" | ||
| deployment_id: ${{ steps.deployment.outputs.deployment_id }} | ||
|
|
||
| - name: Update deployment status (failure) | ||
| if: failure() | ||
| uses: chrnorm/deployment-status@releases/v1 | ||
| with: | ||
| token: "${{ github.token }}" | ||
| target_url: ${{ env.TARGET_URL }} | ||
| state: "failure" | ||
| deployment_id: ${{ steps.deployment.outputs.deployment_id }} |
There was a problem hiding this comment.
same thing here, we don't have deployments nor notifications, so this is not needed.
There was a problem hiding this comment.
I'll update and push.
thdaraujo
added
🏃🏽 PR: In Progress
🙏🏽 PR: Needs Further Updates
and removed
⏲️ PR: In Queue for Review
labels
bijoysijo
changed the title
|
Hi, I've made the requested changes. Let me know if it needs more work. 😄 |
|
@thdaraujo Everything look good? 😄 |
|
LGTM :) |
|
Just waiting on @vbrazo about the keys. |
Add Github action to automate publish to RubyGems on release / tag.
Fixes #2554