Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vehicles generator #2539

Closed
wants to merge 4 commits into from

Conversation

trinaldi
Copy link
Contributor

@trinaldi trinaldi commented Aug 26, 2022

Summary

This PR adds Faker::Vehicles::Car with car brand, model and version.

Other Information

I have to deal with a lot of car related info in my job. I was using a few generic generators to create the brand name, model name and version name, so I decided to create this one myself.

The idea behind Vehicles is to insert not only Car but any vehicle in the future (e.g Motorcycle). I believe this namespace will attract another users, enthusiasts, etc..

This is my PR to this project, so let me know how can I improve it.

This commit adds Faker::Vehicles::Car with car brand, model and version.
@thdaraujo
Copy link
Contributor

thanks for sending this PR @trinaldi!

We currently have a vehicle generator that gives you a make, model, transmission, etc.

Is the intent behind your contribution to reorganize this information under a separate namespace so people can add other types of vehicles in the future, or is this unrelated to the existing information we already have?

https://github.com/faker-ruby/faker/blob/master/lib/locales/en/vehicle.yml

@thdaraujo thdaraujo added the ⌛ PR: Needs More Information When the author needs to provide more information label Aug 26, 2022
@psibi
Copy link
Member

psibi commented Aug 26, 2022

I think this would be helpful and having other vehicles would be nice too. Although as @thdaraujo pointed out, it would be helpful to know more about the intent.

Also I'm not sure why the tests are failing, that needs to be resolved.

@trinaldi
Copy link
Contributor Author

To be honest, I wasn't aware of those Vehicles generator, @thdaraujo, my bad.
My intent was to create a new generator category. Knowing that there's already a Vehicle generator, I can just add to the yml file as @psibi pointed out.

I think we can close this PR, then;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌛ PR: Needs More Information When the author needs to provide more information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants