Drop support for EOL Ruby versions (2.5 and 2.6)

[nick-mendez]

Summary

I Completed the 3 tasks in Issue #2529

• removed version checks in test_faker_birthday_in_leap_year.rb and test_faker_id_number.rb
• Updated Targeted Ruby Version for Rubocop to 2.7
• Updated spec.required_ruby_version = '>= 2.5' to 2.7

Other Information

[thdaraujo]

nice, thanks for working on this!

I left a couple of questions regarding the tests we probably still want to keep.

[thdaraujo]

Yes, we want to remove the tests for version < 2.7 and we don't need the version checks anymore.

But we still want to keep the tests that check that the error raised is a Date::Error, right? I don't think you need to remove them.

[thdaraujo]

what do you think of also removing Ruby versions older than 2.7 from the test matrix?

Here:

faker/.github/workflows/ruby.yml

Line 38 in 4ffc714

- '2.5'

[nick-mendez]

@thdaraujo I removed the ruby versions older than 2.7 from the test matrix and fixed the 2 errors from my previous pull request. Thank you for your help

[nick-mendez]

I revised the two test files to include the errors without the version check. I also removed the older ruby versions ( < 2.7) from the test matrix

[stefannibrasil]

Thank you, @nickmendezFlatiron this is great! I believe there is a duplicated block to be removed. Could you remove it and then we can approve this? Thanks!

[stefannibrasil]

@nickmendezFlatiron if you run rubocop -A, it will fix Rubocop offenses for you 👀

[nick-mendez]

I have made the suggested changes using rubocop and removed the duplicate code from the test file. Thank you for your help

[stefannibrasil]

Awesome, thank you!

[thdaraujo]

LGTM