Fix: Use pattern to define Australian cell phone formats #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattr
force-pushed
the
issue/expand-au-cell-formats
branch
from
436a828 to
ec19a3c
Compare
Restore patterns rather than fictional list as this does not provide sufficient unique cases when testing exclusively Australian numbers. Restrict the set to 041-043 numbers as these ranges are fully allocated and will not generate errors (044-049 can generate errors if using phonelib for validation).
mattr
force-pushed
the
issue/expand-au-cell-formats
branch
from
ec19a3c to
1a1e476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
#2498
Description:
Restore patterns rather than fictional list as this does not provide sufficient unique cases when testing exclusively Australian numbers. Restrict the set to 040-043 numbers as these ranges are fully allocated and will not generate errors (044-049 can generate errors if using phonelib for validation should the number fall in "spare" ranges).
The use of patterns to define valid numbers is inline with other countries in Faker (e.g. US or NZ). The restriction of Australia to fictional numbers seems to be an outlier.