✨ Add Faker::Movies::Tron #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just rebased, looks like it might be good to go now. |
psibi
requested changes
Apr 6, 2022
📝 Update documentation to match 📝 Update documented version number
|
Updated, let me know if you want me to squash the branch. |
psibi
reviewed
Apr 6, 2022
lib/faker/movies/tron.rb
Outdated
| # @example | ||
| # Faker::Movies::Tron.character #=> "Bit" | ||
| # | ||
| # @faker.version 2.15.1 |
There was a problem hiding this comment.
The version needs to be next here and at below. Sorry that I missed this in my initial review. LGTM apart from that.
There was a problem hiding this comment.
Dang... I changed the markdown file and missed this. When you say next should I put in 2.21.0 or is there a special placeholder I put in?
There was a problem hiding this comment.
Yeah, you put next instead of 2.15.1. There are more details here: https://github.com/faker-ruby/faker/blob/master/CONTRIBUTING.md
psibi
reviewed
Apr 6, 2022
📝 Removed version number from MarkDown file
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-StoryDescription:
Adding TRON (original 1982 version) to Faker.
Going to use this for a system that is taking the name Master Control Program in acknowledgement of the original inspiration of my career path.
I think that other users of faker would appreciate the overlap of terms and quotes that exist between this movie and what we do on a day-to-day basis.