Rubocop 1.0 fixes #2182
Merged
Rubocop 1.0 fixes #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatsuda
force-pushed
the
rubocop_1_0_fixes
branch
from
9985e91 to
b318488
Compare
This empty file was introduced at the initial commit for this michael_scott faker: bcb8cf0 The actual tests are written in another file: test/faker/tv_shows/test_michael_scott.rb
amatsuda
force-pushed
the
rubocop_1_0_fixes
branch
from
b318488 to
4e3cc3a
Compare
|
Sorry for pushing a broken branch. Just fixed all the CI failures and now it's all green! |
vbrazo
approved these changes
Oct 28, 2020
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are possible fixes for Rubocop 1.0 offences. The CI should be green with this patch!
related #2181
/cc @Zeragamba @koic