Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jack Handey's Deep Thoughts to quotes #2150

Merged
merged 8 commits into from
Oct 11, 2020

Conversation

fiteclub
Copy link
Contributor

@fiteclub fiteclub commented Oct 8, 2020

Issue#

No-Story

Description:

Adds Jack Handey's Deep Thoughts to Faker::Quote. Featured on SNL in the 90's, these are surrealistic one-liner jokes.

Faker::Quote.jack_handey

  • Useful in generating Quote of the Day messages, interesting form fills, or insane bot banter.

lib/faker/quotes/jack_handey.rb Outdated Show resolved Hide resolved
lib/locales/en/jack_handey.yml Outdated Show resolved Hide resolved
lib/locales/en/jack_handey.yml Outdated Show resolved Hide resolved
lib/faker/quotes/jack_handey.rb Outdated Show resolved Hide resolved
lib/faker/quotes/quote.rb Outdated Show resolved Hide resolved
@Zeragamba Zeragamba merged commit 48c5c02 into faker-ruby:master Oct 11, 2020
@Zeragamba
Copy link
Contributor

Thanks!

@fiteclub
Copy link
Contributor Author

Would you kindly be able to tag this PR as hacktoberfest-accepted, please?

@fiteclub
Copy link
Contributor Author

Thank you!

droznyk pushed a commit to droznyk/faker that referenced this pull request Oct 23, 2020
* Add Deep Thoughts by Jack Handey quotes

* Convert yaml to use literals

* Add quotes and fix formatting

* Remove duplicate quotes

* Remove close-duplicate quotes

* Move to Faker::Quote.deep_thoughts, reduce & reformat .yml

* Move to Faker::Quote.jack_handey
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants