-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jack Handey's Deep Thoughts to quotes #2150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathisto
approved these changes
Oct 9, 2020
Zeragamba
suggested changes
Oct 10, 2020
Zeragamba
suggested changes
Oct 10, 2020
Zeragamba
approved these changes
Oct 11, 2020
Thanks! |
Would you kindly be able to tag this PR as |
Thank you! |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
* Add Deep Thoughts by Jack Handey quotes * Convert yaml to use literals * Add quotes and fix formatting * Remove duplicate quotes * Remove close-duplicate quotes * Move to Faker::Quote.deep_thoughts, reduce & reformat .yml * Move to Faker::Quote.jack_handey
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit 34aba81.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit 34aba81.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-Story
Description:
Adds Jack Handey's Deep Thoughts to Faker::Quote. Featured on SNL in the 90's, these are surrealistic one-liner jokes.
Faker::Quote.jack_handey