Fixes a bug when generating a password with min_length eq 1 #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeragamba
suggested changes
Oct 2, 2020
adrian-rivera
force-pushed
the
fix_1770
branch
3 times, most recently
from
c14ca82 to
b5e2266
Compare
adrian-rivera
force-pushed
the
fix_1770
branch
from
b5e2266 to
8cea85f
Compare
Zeragamba
approved these changes
Oct 2, 2020
Oh... that ticks off Rubocop. Nvm. Reverting back to the original version
Zeragamba
approved these changes
Oct 2, 2020
|
Thanks! |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…by#2138) * Fixes a bug when generating passwords with min_length eq 1 * swap if block for brackets * Update internet.rb Oh... that ticks off Rubocop. Nvm. Reverting back to the original version Co-authored-by: Stephen A. Wilson <[email protected]>
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…aker-ruby#2138)" This reverts commit 47bc44e.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
…aker-ruby#2138)" This reverts commit 47bc44e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
#1770
Description:
As describe on #1770 running a command like this:
caused an error, the root cause is the parameter min_length, which raises an argument error when
mix_caseis set to true.With this fix setting
min_lengthto 1 won't cause this exception.