Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Super Mario #2135

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Add Super Mario #2135

merged 2 commits into from
Oct 2, 2020

Conversation

fblupi
Copy link
Contributor

@fblupi fblupi commented Oct 1, 2020

Issue#

No-Story

Description:

Add a generator to generate a random character or game of the Super Mario series. Examples:

# Random Super Mario character
Faker::Games::SuperMario.character #=> "Luigi"

# Random Super Mario game
Faker::Games::SuperMario.game #=> "Super Mario Odyssey"

@Zeragamba Zeragamba merged commit eb09126 into faker-ruby:master Oct 2, 2020
@Zeragamba
Copy link
Contributor

Thanks!

droznyk pushed a commit to droznyk/faker that referenced this pull request Oct 23, 2020
@fblupi @droznyk
Add Super Mario (faker-ruby#2135)
4626a4a 
* Add Super Mario

* Add Super Mario Locations
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
@droznyk
Revert "Add Super Mario (faker-ruby#2135)"
c68620c 
This reverts commit 4626a4a.
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
@droznyk
Revert "Add Super Mario (faker-ruby#2135)"
6fb2786 
This reverts commit 4626a4a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeragamba Zeragamba Zeragamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fblupi @Zeragamba