Enable Ruby testing github workflow #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Travis builds reported results back to code climate, and this restores that. @stympy We should move the the CC Reporter Id to the [repo's secrets](https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets) and regenerate it (for safety). I'm unable to do that as accessing the repo's secrets requires `admin` permissions.
connorshea
reviewed
May 19, 2020
|
|
||
| - name: Publish code coverage | ||
| env: | ||
| CC_TEST_REPORTER_ID: c9b8356df2031a5a72462555fe898245cf24d83c7bb82c40ddb5c6c6976c4319 |
There was a problem hiding this comment.
🤔 is this supposed to be a secret?
There was a problem hiding this comment.
Yes, but it was also in the .travis.yml file. @stympy (or someone with admin perms) will need to move it to the repo's secrets and regenerate it.
There was a problem hiding this comment.
Not sure if I have access to the Travis account. I wonder if we should create a new GitHub user for Faker and assign these responsibilities to this user. I like this idea because all the members of the Faker organization would be able to change the settings.
There was a problem hiding this comment.
Reading this codeclimate/ruby-test-reporter#34, I guess we should be ok to keep this key public.
connorshea
approved these changes
May 20, 2020
This was referenced May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable testing of Faker via Github Actions