Data source fix for ha locale #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of the changes: * `country_code` should be under address * `city_suffix` is empty and isn't used anywhere * `direction` doesn't contain any data for compass. Only when cardinal, ordinal and half wind has direction fields, this should be present.
|
Have pushed a commit which will hopefully fix the failing tests. The test seems to have the wrong assumption that |
vbrazo
approved these changes
Jan 19, 2020
|
Phew! The tests has been finally fixed. |
|
@vbrazo Thanks for merging this and the other MR's! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
country_codeshould be under addresscity_suffixis empty and isn't used anywheredirectiondoesn't contain any data for compass. Only whencardinal, ordinal and half wind has direction fields, this should be
present.