Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new heroes, new maps and almost all of the quotes #1839

Merged
merged 3 commits into from
Nov 24, 2019
Merged

added new heroes, new maps and almost all of the quotes #1839

merged 3 commits into from
Nov 24, 2019

Conversation

EduardoCerutti
Copy link
Contributor

Issue #1795

Example:

#1795

Description:

I added all of the new hores, new maps and almost all of the quotes per hero.
I made an algorithm to catch the quotes from the website https://overwatch.gamepedia.com/Category:Quotations

@EduardoCerutti EduardoCerutti changed the title added new hores, new maps and almost all of the quotes added new heroes, new maps and almost all of the quotes Nov 20, 2019
@EduardoCerutti EduardoCerutti mentioned this pull request Nov 20, 2019
Closed
vbrazo
vbrazo approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit 6d4da4e into faker-ruby:master Nov 24, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@EduardoCerutti @michebble
added new heroes, new maps and almost all of the quotes (faker-ruby#1839
6fb2043 
)

* added new hores, new maps and almost all of the quotes

* bug fix links after some quotes

* bug fix double " at the end of some quotes
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@EduardoCerutti @vbrazo
added new heroes, new maps and almost all of the quotes (faker-ruby#1839
5e58f69 
)

* added new hores, new maps and almost all of the quotes

* bug fix links after some quotes

* bug fix double " at the end of some quotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@EduardoCerutti EduardoCerutti

Labels
🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EduardoCerutti @vbrazo