-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds domain option for Internet email and domain_name methods #1808
Adds domain option for Internet email and domain_name methods #1808
Conversation
@tiagofsilva One cool thing is that if you include the words The PR looks grand and solves my problem perfectly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however we're missing documentation in this PR. Please add them!
About the email section: add
Add an example:
And in the
|
Thanks @olleolleolle and @vbrazo ! Here are the documentation's changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet. Thanks 💥
…ruby#1808) * Adds domain option for Internet.email and Internet.domain_name methods * Renames variable to avoid violating rubocop * Adds documentation to modified Internet.email and Internet.domain methods
…ruby#1808) * Adds domain option for Internet.email and Internet.domain_name methods * Renames variable to avoid violating rubocop * Adds documentation to modified Internet.email and Internet.domain methods
Issue #1624
Example:
Description:
This PR's main goal is to add another option to Internet.email method (fixes #1624), which is the
domain
param. Also makes possible to generate adomain_name
with a custom domain and random subdomain.