Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two new locales added: th and en-TH #1773

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Two new locales added: th and en-TH #1773

merged 1 commit into from
Sep 30, 2019

Conversation

kodram
Copy link

@kodram kodram commented Sep 30, 2019

Two new locales added:

  • th
  • en-TH

only two methods are available in them:

  • Faker::Name.first_name
  • Faker::Name.last_name

vbrazo
vbrazo reviewed Sep 30, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does th mean?

@kodram
Copy link
Author

kodram commented Sep 30, 2019

Thailand

https://en.wikipedia.org/wiki/ISO_3166-2:TH

@firedev
Copy link

firedev commented Sep 30, 2019

This is a port of the following pull request to ffaker ffaker/ffaker#299, we would like to migrate to faker now.

vbrazo
vbrazo approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the awesome th locale. I really wanna go to Thailand someday 🏖🍺

Thanks for contributing 💥

@vbrazo
Copy link
Member

vbrazo commented Sep 30, 2019 •
edited
Loading

@firedev your th contributions will be welcome here

@vbrazo vbrazo merged commit a98d289 into faker-ruby:master Sep 30, 2019
vbrazo pushed a commit that referenced this pull request Sep 30, 2019
@dependabot-preview @vbrazo
Update test-unit requirement from = 3.3.3 to = 3.3.4 (#1774)
3b8816d 
* Two new locales added: th and en-th (#1773)

* Bump version to 2.5.0

* Update test-unit requirement from = 3.3.3 to = 3.3.4

Updates the requirements on [test-unit](https://github.com/test-unit/test-unit) to permit the latest version.
- [Release notes](https://github.com/test-unit/test-unit/releases)
- [Commits](test-unit/test-unit@3.3.3...3.3.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>
vbrazo pushed a commit that referenced this pull request Sep 30, 2019
@dependabot-preview @vbrazo
Update rake requirement from = 12.3.3 to = 13.0.0 (#1776)
e4dd178 
* Two new locales added: th and en-th (#1773)

* Bump version to 2.5.0

* Update rake requirement from = 12.3.3 to = 13.0.0

Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](ruby/rake@v12.3.3...v13.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@dependabot-preview @michebble
Update test-unit requirement from = 3.3.3 to = 3.3.4 (faker-ruby#1774)
fa9a4dc 
* Two new locales added: th and en-th (faker-ruby#1773)

* Bump version to 2.5.0

* Update test-unit requirement from = 3.3.3 to = 3.3.4

Updates the requirements on [test-unit](https://github.com/test-unit/test-unit) to permit the latest version.
- [Release notes](https://github.com/test-unit/test-unit/releases)
- [Commits](test-unit/test-unit@3.3.3...3.3.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@dependabot-preview @michebble
Update rake requirement from = 12.3.3 to = 13.0.0 (faker-ruby#1776)
422f31b 
* Two new locales added: th and en-th (faker-ruby#1773)

* Bump version to 2.5.0

* Update rake requirement from = 12.3.3 to = 13.0.0

Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](ruby/rake@v12.3.3...v13.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@dependabot-preview @vbrazo
Update test-unit requirement from = 3.3.3 to = 3.3.4 (faker-ruby#1774)
c69d006 
* Two new locales added: th and en-th (faker-ruby#1773)

* Bump version to 2.5.0

* Update test-unit requirement from = 3.3.3 to = 3.3.4

Updates the requirements on [test-unit](https://github.com/test-unit/test-unit) to permit the latest version.
- [Release notes](https://github.com/test-unit/test-unit/releases)
- [Commits](test-unit/test-unit@3.3.3...3.3.4)

Signed-off-by: dependabot-preview[bot] <[email protected]>
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@dependabot-preview @vbrazo
Update rake requirement from = 12.3.3 to = 13.0.0 (faker-ruby#1776)
a0848a6 
* Two new locales added: th and en-th (faker-ruby#1773)

* Bump version to 2.5.0

* Update rake requirement from = 12.3.3 to = 13.0.0

Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version.
- [Release notes](https://github.com/ruby/rake/releases)
- [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc)
- [Commits](ruby/rake@v12.3.3...v13.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@kodram kodram

Labels
💡 Issue: Feature Request 🌐 Update Locales
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kodram @firedev @vbrazo