Add mock data for Apple OAuth #1738
Conversation
There was a problem hiding this comment.
Thanks for this! Just need to update the docs: https://github.com/faker-ruby/faker/blob/master/doc/default/omniauth.md
Also, YARD docs are in the pipeline if you want to add some to the apple method 😄
| @@ -341,6 +341,40 @@ def github(legacy_name = NOT_GIVEN, legacy_email = NOT_GIVEN, legacy_uid = NOT_G | |||
| } | |||
| end | |||
|
|
|||
| def apple(name: nil, email: nil, uid: nil) | |||
There was a problem hiding this comment.
What about uid: SecureRandom.uuid instead of uid: nil?
There was a problem hiding this comment.
I've just noticed that the def linkedin signature and the other methods in this faker generator are setting uid as Number.number(digits: 6).to_s. SecureRandom.uuid sounds better to me.
There was a problem hiding this comment.
When using SecureRandom directly I was getting a spec failure:
Error: test_determinism(TestDeterminism): RuntimeError: Faker::Omniauth.apple has an entropy leakThe actual uid value from Apple is someting like 001547.2524340274204e7ab773480dd4359bd3.2354, which is where the number+hex+number pattern came from. I set it nil in the method signature and then reassigned in the method body just for line length reasons.
There was a problem hiding this comment.
If the format is different, SecureRandom wouldn't be a good choice. If you want to generate the same format, I'd recommend using bothify just like we did here, otherwise leave it as it is.
There was a problem hiding this comment.
I tried using bothify but the inner bit is a hex value, so letterify didn't provide valid data. We could add a hexify method?
* Add mock data for Apple OAuth * Add docs for mocks
* Add mock data for Apple OAuth * Add docs for mocks
Issue#
No-StoryDescription:
Adds a mock for Apple OAuth,
Faker::Omniauth.apple. This supports testing theomniauth-applegem.There is an interesting gotcha with Apple OAuth, that they only return the email data the first time a user authenticates. I erred on the side of having it always available rather than never, but if there's a better way to represent that, I'm definitely open to it. Maybe
Faker::Omniauth.apple(email: false)