Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix number(digits: 1) always returns 0 #1712

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Fix number(digits: 1) always returns 0 #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e968744
Fix number(digits: 1) always returns 0
ianlet Aug 29, 2019
5f4eff9
remove unnecessary Base
ianlet Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/faker/default/number.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ def number(legacy_digits = NOT_GIVEN, digits: 10)
end

return if digits < 1
return 0 if digits == 1
return rand(0..9).round if digits == 1

# Ensure the first digit is not zero
([non_zero_digit] + generate(digits - 1)).join.to_i
Expand Down
27 changes: 13 additions & 14 deletions test/faker/default/test_faker_number.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,20 @@ def test_number
assert @tester.number(digits: 1).to_s.length == 1
end

def test_number_with_one_digit
random_number = 4
in_range = lambda { |range|
assert_equal(0..9, range)
random_number
}

Faker::Base.stub(:rand, in_range) do
assert_equal(random_number, @tester.number(digits: 1))
end
end

def test_decimal
assert @tester.decimal(l_digits: 1, r_digits: 1).to_s.match(/[0-9]{1}\.[0-9]{1}/)
assert @tester.decimal(l_digits: 2).to_s.match(/[0-9]{2}\.[0-9]{2}/)
assert @tester.decimal(l_digits: 4, r_digits: 5).to_s.match(/[0-9]{4}\.[0-9]{5}/)
end
Expand Down Expand Up @@ -115,18 +128,4 @@ def test_hexadecimal
assert @tester.hexadecimal(digits: 4).match(/[0-9a-f]{4}/)
assert @tester.hexadecimal(digits: 7).match(/[0-9a-f]{7}/)
end

def test_insignificant_zero
@tester.stub :digit, 0 do
assert_equal '0', @tester.number(digits: 1).to_s
100.times do
assert_match(/^[1-9]0/, @tester.number(digits: 2).to_s)
end

assert_equal 0.0, @tester.decimal(l_digits: 1, r_digits: 1)
100.times do
assert_match(/^0\.0[1-9]/, @tester.decimal(l_digits: 1, r_digits: 2).to_s)
end
end
end
end