Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the internet faker docs for v1.9.2 and unreleased. #1522

Merged
merged 1 commit into from
Feb 2, 2019

Conversation

mrstebo
Copy link
Contributor

@mrstebo mrstebo commented Feb 1, 2019

Extends PR #1478 by fixing the docs in the above folders.

@vbrazo
Copy link
Member

vbrazo commented Feb 2, 2019

Indeed the first letter of the string should always be capitalized: https://github.com/stympy/faker/blob/master/lib/faker/default/internet.rb#L68

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbrazo vbrazo merged commit 94cb165 into faker-ruby:master Feb 2, 2019
@mrstebo mrstebo deleted the fix-internet-password-docs branch February 2, 2019 09:22
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants