Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faker::Vehicle.vin generates invalid vins #2473

Closed
Codball opened this issue Mar 24, 2022 · 0 comments · Fixed by #2475
Closed

Faker::Vehicle.vin generates invalid vins #2473

Codball opened this issue Mar 24, 2022 · 0 comments · Fixed by #2475

Comments

@Codball
Copy link

Codball commented Mar 24, 2022 •
edited
Loading

Describe the bug

I have noticed the function generating vins with I, O, and Q.
Example: "NT8Q9DQASR0M09679"

To Reproduce

  1. Generate vin with function
  2. Copy paste into vindecoderz.com

Expected behavior

Vins to pass validation

Additional context

Not sure if there are other issues with the regex generating this string but I know vins can be kind of complicated
@Codball Codball changed the title Faker::Vehicle.vin generates invalid vins Faker::Vehicle.vin generates invalid vins Mar 24, 2022
@erayalkis erayalkis mentioned this issue Apr 2, 2022
Merged
bodiam added a commit to datafaker-net/datafaker that referenced this issue Apr 3, 2022
@bodiam
imp(vin): Vehicle vins no longer create vins starting with I, O and Q (…
8ec19a5 
…faker-ruby/faker#2473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update regex used for Faker::Vehicle#vin erayalkis/faker
1 participant
@Codball