-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: name module gender #644
Conversation
Codecov Report
@@ Coverage Diff @@
## main #644 +/- ##
=======================================
Coverage 99.33% 99.34%
=======================================
Files 1923 1923
Lines 176841 176837 -4
Branches 911 900 -11
=======================================
+ Hits 175671 175678 +7
+ Misses 1114 1103 -11
Partials 56 56
|
Should we go ahead and add support for the gender non-binary in this PR? You're setting up the types and infrastructure, which is good, but maybe we should add |
I would do that in v6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first step. We'll tackle Non Binary support in 6.2 then 👍🏻
No description provided.