refactor(locale): fix various locale data with trailing spaces #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the case of ar/location/state and hr/location/street_name, this was also a duplicate of a line without a space, so removed.
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
although this breaks the rule of keeping PRs to a single module, i think its quick to review as a batch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3329 +/- ##
==========================================
- Coverage 99.97% 99.96% -0.01%
==========================================
Files 2806 2806
Lines 217086 217084 -2
Branches 975 966 -9
==========================================
- Hits 217032 217014 -18
- Misses 54 70 +16
|
ST-DDT
approved these changes
Dec 5, 2024
ST-DDT
changed the title
There are a few cases where trailing or leading spaces seem intentional such as some prefixes and suffixes. So perhaps not. |
xDivisionByZerox
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove data which incorrectly ends with a trailing space.
in the case of ar/location/state and hr/location/street_name, this was also a duplicate of a line without a space, so removed.