Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): re-moo-ved some incorrect cow data #3326

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

matthewmayer
Copy link
Contributor

My guess is when this was introduced in

1914b96

this was a copy-paste from something like Wikipedia, and there were some alphabetical markers like “A - edit” “B - edit” which made their way into the data

My guess is when this was introduced in

1914b96

this was a copy-paste from something like Wikipedia, and there were some alphabetical markers like “A - edit” “B - edit” which made their way into the data
@matthewmayer matthewmayer requested a review from a team as a code owner December 5, 2024 14:06
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c87d4e5
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6751b3545348a800083f46a8
😎 Deploy Preview https://deploy-preview-3326.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer self-assigned this Dec 5, 2024
@matthewmayer matthewmayer added c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (1bfa1fa) to head (c87d4e5).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3326      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217086   217061      -25     
  Branches      975      968       -7     
==========================================
- Hits       217027   216990      -37     
- Misses         59       71      +12     
Files with missing lines Coverage Δ
src/locales/en/animal/cow.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT changed the title fix(animal): re-moo-ved some incorrect cow data refactor(locale): re-moo-ved some incorrect cow data Dec 5, 2024
@ST-DDT ST-DDT requested review from a team December 5, 2024 14:18
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Dec 5, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 5, 2024
@xDivisionByZerox
Copy link
Member

Title is a 10 / 10 👍😂🐮

@ST-DDT ST-DDT added this pull request to the merge queue Dec 6, 2024
Merged via the queue into faker-js:next with commit 47f835b Dec 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants