feat(person): use fake patterns for jobTitle #2528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently faker.person.jobTitle is hardcoded to use the order:
{{person.jobDescriptor}} {{person.jobArea}} {{person.jobType}}
e.g. Senior Marketing Executive
However in some languages, like Spanish or French, typically the adjectives would follow the noun ie
type area descriptor
And in some languages like Thai or Chinese although they follow an English word order, there should be no spaces between the parts.
This PR permits better localization by allowing a fake pattern for the job title. I just added English and Spanish for now as demos, other languages could be added as needed. If no job_title_pattern is found it would fall back to en, keeping current behavior.