Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in CONTRIBUTING.md #2264

Merged
merged 1 commit into from Jul 19, 2023
Merged

docs: fix typo in CONTRIBUTING.md #2264

merged 1 commit into from Jul 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2023

I just fixed a typo in CONTRIBUTING.md that I spotted while working on PR #2227.

@ghost ghost self-requested a review July 19, 2023 17:14
@ghost ghost self-requested a review as a code owner July 19, 2023 17:14
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2264 (3958bbf) into next (3df98a0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2264      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2638     2638              
  Lines      244684   244684              
  Branches     1083     1081       -2     
==========================================
- Hits       243715   243699      -16     
- Misses        942      958      +16     
  Partials       27       27              

see 1 file with indirect coverage changes

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jul 19, 2023
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for extracting this into its own PR :)

@ST-DDT ST-DDT merged commit 8530a3e into faker-js:next Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants