Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy locale folder #2263

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jul 17, 2023

The locale folder was a relic from faker v5.5.3 times and was there to support NodeJS v12 and below that didn't know the package.json's exports field
We don't support the NodeJS versions anymore, and so it is even not possible to access this folder anymore, as the try to do this would result always in the dist folder via the exports mapping

FFR: https://nodejs.org/api/packages.html

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jul 17, 2023
@Shinigami92 Shinigami92 self-assigned this Jul 17, 2023
@Shinigami92 Shinigami92 added the s: needs decision Needs team/maintainer decision label Jul 17, 2023
@Shinigami92 Shinigami92 marked this pull request as ready for review July 17, 2023 20:01
@Shinigami92 Shinigami92 requested a review from a team as a code owner July 17, 2023 20:01
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #2263 (0eff5bb) into next (5f947cb) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2263      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.02%     
==========================================
  Files        2638     2638              
  Lines      244684   244684              
  Branches     1085     1082       -3     
==========================================
- Hits       243722   243694      -28     
- Misses        935      963      +28     
  Partials       27       27              

see 3 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team July 17, 2023 20:03
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Jul 17, 2023
@Shinigami92 Shinigami92 merged commit 3df98a0 into next Jul 18, 2023
@Shinigami92 Shinigami92 deleted the kill-locale-fallback-with-fire branch July 18, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants