Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add reproducible results section #1892

Merged
merged 4 commits into from
Mar 14, 2023
Merged

docs: add reproducible results section #1892

merged 4 commits into from
Mar 14, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Mar 4, 2023 •
edited
Loading

Improved docs re #1870 to "usage" page

@matthewmayer matthewmayer requested a review from a team March 4, 2023 11:04
@matthewmayer matthewmayer requested a review from a team as a code owner March 4, 2023 11:04
@matthewmayer matthewmayer mentioned this pull request Mar 4, 2023
Closed
10 tasks
@codecov
Copy link

codecov bot commented Mar 4, 2023 •
edited
Loading

Codecov Report

Merging #1892 (837460e) into next (a943353) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 837460e differs from pull request most recent head 64c447d. Consider uploading reports for the commit 64c447d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #1892      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2357     2357              
  Lines      236815   236564     -251     
  Branches     1221     1191      -30     
==========================================
- Hits       235933   235678     -255     
- Misses        860      864       +4     
  Partials       22       22

see 38 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Mar 4, 2023
View reviewed changes
Shinigami92
Shinigami92 reviewed Mar 4, 2023
View reviewed changes
docs/guide/usage.md Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Mar 4, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from Shinigami92 and a team March 4, 2023 23:28
@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Mar 4, 2023
@ST-DDT ST-DDT linked an issue Mar 5, 2023 that may be closed by this pull request
Faker dates are not reproducible with fixed seed. #1870
Closed
10 tasks
ejcheng
ejcheng previously approved these changes Mar 7, 2023
View reviewed changes
Shinigami92
Shinigami92 previously approved these changes Mar 8, 2023
View reviewed changes
xDivisionByZerox
xDivisionByZerox requested changes Mar 8, 2023
View reviewed changes
docs/guide/usage.md Outdated Show resolved Hide resolved
@matthewmayer matthewmayer dismissed stale reviews from Shinigami92, ejcheng, and ST-DDT via 837460e March 14, 2023 09:49
@ST-DDT ST-DDT enabled auto-merge (squash) March 14, 2023 20:01
@ST-DDT ST-DDT merged commit 6841e3d into faker-js:next Mar 14, 2023
@matthewmayer matthewmayer mentioned this pull request Mar 25, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng ejcheng approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@Shinigami92 Shinigami92 Shinigami92 left review comments

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Faker dates are not reproducible with fixed seed.
5 participants
@matthewmayer @ST-DDT @Shinigami92 @ejcheng @xDivisionByZerox