Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(commerce): price use options object #1805

Merged
merged 4 commits into from
Feb 6, 2023
Merged

refactor(commerce): price use options object #1805

merged 4 commits into from
Feb 6, 2023

Conversation

xDivisionByZerox
Copy link
Member

Part of #1349.

Standardize all the price function in the CommerceModule to support an options object. Furthermore, deprecate the multi-argument signature for maintainability purposes.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: commerce Something is referring to the commerce module deprecation A deprecation was made in the PR labels Feb 1, 2023
@xDivisionByZerox xDivisionByZerox requested a review from a team February 1, 2023 23:12
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner February 1, 2023 23:12
@xDivisionByZerox xDivisionByZerox self-assigned this Feb 1, 2023
@xDivisionByZerox xDivisionByZerox linked an issue Feb 1, 2023 that may be closed by this pull request
Standardize function parameters and defaults #1349
Closed
@codecov
Copy link

codecov bot commented Feb 1, 2023 •
edited
Loading

Codecov Report

Merging #1805 (c381491) into next (1b9ca01) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #1805    +/-   ##
========================================
  Coverage   99.62%   99.63%            
========================================
  Files        2346     2346            
  Lines      235519   235646   +127     
  Branches     1137     1142     +5     
========================================
+ Hits       234642   234790   +148     
+ Misses        855      834    -21     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/commerce/index.ts 100.00% <100.00%> (ø)
src/modules/location/index.ts 98.70% <0.00%> (-0.22%) ⬇️
src/modules/git/index.ts 100.00% <0.00%> (+0.92%) ⬆️
src/modules/internet/user-agent.ts 94.08% <0.00%> (+6.21%) ⬆️

@ST-DDT ST-DDT requested a review from a team February 1, 2023 23:58
@Shinigami92 Shinigami92 enabled auto-merge (squash) February 6, 2023 09:39
@Shinigami92 Shinigami92 merged commit 8766fd7 into next Feb 6, 2023
@xDivisionByZerox xDivisionByZerox deleted the refactor/commerce/normalize-parameters branch February 11, 2023 16:24
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
@xDivisionByZerox @matthewmayer
refactor(commerce): price use options object (faker-js#1805)
15b73da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Standardize function parameters and defaults
3 participants
@xDivisionByZerox @ST-DDT @Shinigami92